Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?]: with-trpc is breaking - seroval issue #1092

Closed
2 tasks done
birkskyum opened this issue Oct 24, 2023 · 6 comments
Closed
2 tasks done

[Bug?]: with-trpc is breaking - seroval issue #1092

birkskyum opened this issue Oct 24, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@birkskyum
Copy link
Contributor

birkskyum commented Oct 24, 2023

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

When starting the example, with Node 18, this is the result:

GET http://localhost:3000/
GET http://localhost:3000/api/trpc/example.hello?batch=1&input=%7B%220%22%3A%22World%22%7D
An unhandled error occured: Error: Cannot serialize function without reference ID.
    at Re (file:///Users/admin/repos/solid-start/node_modules/.pnpm/[email protected]/node_modules/seroval/dist/esm/production/index.mjs:3:30635)

Also note, the example uses an archived solid-trpc package.

Expected behavior 🤔

that the server starts

Steps to reproduce 🕹

Steps:

  1. checkout latest main in solid-start
  2. Use node 18
  3. pnpm i
  4. go to examples/with-trpc
  5. run pnpm run dev

Context 🔦

Might be related to other recent seroval issues:

Your environment 🌎

No response

@birkskyum birkskyum added the bug Something isn't working label Oct 24, 2023
@birkskyum birkskyum mentioned this issue Oct 24, 2023
10 tasks
@sysmat
Copy link

sysmat commented Nov 3, 2023

"type": "module",
  "devDependencies": {
    "@types/node": "^20.8.10",
    "csstype": "3.1.2",
    "esbuild": "^0.19.5",
    "postcss": "^8.4.31",
    "rollup": "^4.2.0",
    "solid-start-node": "^0.3.9",
    "typescript": "^5.2.2",
    "vite": "^4.5.0"
  },
  "dependencies": {
    "@solidjs/meta": "^0.29.1",
    "@solidjs/router": "^0.8.3",
    "drizzle-orm": "^0.28.6",
    "mysql2": "^3.6.3",
    "solid-js": "^1.8.5",
    "solid-start": "^0.3.9"
  },
  "engines": {
    "node": ">=18"
  }
  • list
├─┬ @solidjs/[email protected] -> .\node_modules\.pnpm\@[email protected][email protected]\node_modules\@solidjs\meta
│ └─┬ [email protected] -> .\node_modules\.pnpm\[email protected]\node_modules\solid-js
│   └── [email protected] deduped -> .\node_modules\.pnpm\[email protected]\node_modules\seroval
├─┬ @solidjs/[email protected] -> .\node_modules\.pnpm\@[email protected][email protected]\node_modules\@solidjs\router
│ └─┬ [email protected] -> .\node_modules\.pnpm\[email protected]\node_modules\solid-js
│   └── [email protected] deduped -> .\node_modules\.pnpm\[email protected]\node_modules\seroval
├─┬ [email protected] -> .\node_modules\.pnpm\[email protected]\node_modules\solid-js
│ └── [email protected] -> .\node_modules\.pnpm\[email protected]\node_modules\seroval
└─┬ [email protected] -> .\node_modules\.pnpm\[email protected]_@[email protected]_@[email protected][email protected][email protected][email protected]\node_modules\solid-start
  ├─┬ [email protected] -> .\node_modules\.pnpm\[email protected][email protected][email protected]\node_modules\esbuild-plugin-solid       
  │ └─┬ [email protected] -> .\node_modules\.pnpm\[email protected]\node_modules\solid-js
  │   └── [email protected] deduped -> .\node_modules\.pnpm\[email protected]\node_modules\seroval
  ├─┬ [email protected] -> .\node_modules\.pnpm\[email protected]\node_modules\solid-js
  │ └── [email protected] deduped -> .\node_modules\.pnpm\[email protected]\node_modules\seroval
  └─┬ [email protected] -> .\node_modules\.pnpm\[email protected][email protected][email protected]\node_modules\vite-plugin-solid
    ├─┬ [email protected] -> .\node_modules\.pnpm\[email protected]\node_modules\solid-js
    │ └── [email protected] deduped -> .\node_modules\.pnpm\[email protected]\node_modules\seroval
    └─┬ [email protected] -> .\node_modules\.pnpm\[email protected][email protected]\node_modules\solid-refresh
      └─┬ [email protected] -> .\node_modules\.pnpm\[email protected]\node_modules\solid-js
        └── [email protected] deduped -> .\node_modules\.pnpm\[email protected]\node_modules\seroval

@sysmat
Copy link

sysmat commented Nov 7, 2023

any progress?

@sysmat
Copy link

sysmat commented Nov 8, 2023

this totally stopper

@birkskyum
Copy link
Contributor Author

@OrJDev - do you think this can be solved by updating to mediakit, or is there an issue with seroval still?

@ItsGPhillips
Copy link

ItsGPhillips commented Nov 18, 2023

This has killed progress on one of my apps, this should be an urgent issue

@ryansolid
Copy link
Member

I remade the TRPC example in the new Beta and didn't face this issue. In general though I stopped using Tanstack Query for the example and that might be where the issue lies. Something with how hydration/serialization is working.

In setting up for SolidStart's next Beta Phase built on Nitro and Vinxi we are closing all PRs/Issues that will not be merged due to the system changing. If you feel your issue was closed by mistake. Feel free to re-open it after updating/testing against 0.4.x release. Thank you for your patience.

See #1139 for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants