Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?]: Extend Solid config causes TS Errors #1464

Closed
2 tasks done
ryoid opened this issue May 2, 2024 · 2 comments
Closed
2 tasks done

[Bug?]: Extend Solid config causes TS Errors #1464

ryoid opened this issue May 2, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@ryoid
Copy link
Contributor

ryoid commented May 2, 2024

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

Extending solid config has required fields that should be optional.

// app.config.ts
export default defineConfig({
  solid: {
    // Uncomment to supress errors
    // dev: true,
    // ssr: false,
    // hot: true,
    // solid: {
    //   omitNestedClosingTags: false,
    // },
    babel: {
      env: {
        development: {
          // https://github.com/nksaraf/vinxi/issues/204
          compact: true,
        },
      },
    },
  },
});

Expected behavior 🤔

Should not error since these fields have default values. Looking at vite-plugin-solid it seems like these are optional there.

Steps to reproduce 🕹

https://stackblitz.com/edit/github-e58cde-3el8ng?file=package.json

Steps:

  1. Extend the Solid config in app.config.ts with some babel settings
  2. Observe typescript errors

Context 🔦

Encountered when trying to use config from nksaraf/vinxi#204 (comment)

Your environment 🌎

No response

@ryoid ryoid added the bug Something isn't working label May 2, 2024
@ryansolid
Copy link
Member

Yeah we fixed this in 2.10.x of Vite Plugin Solid but Start hasn't been updated to it. Thanks for pointing this out.

@ryansolid
Copy link
Member

This has been fixed in 7ae0541

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants