We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extending solid config has required fields that should be optional.
// app.config.ts export default defineConfig({ solid: { // Uncomment to supress errors // dev: true, // ssr: false, // hot: true, // solid: { // omitNestedClosingTags: false, // }, babel: { env: { development: { // https://github.com/nksaraf/vinxi/issues/204 compact: true, }, }, }, }, });
Should not error since these fields have default values. Looking at vite-plugin-solid it seems like these are optional there.
vite-plugin-solid
https://stackblitz.com/edit/github-e58cde-3el8ng?file=package.json
Steps:
app.config.ts
Encountered when trying to use config from nksaraf/vinxi#204 (comment)
No response
The text was updated successfully, but these errors were encountered:
Yeah we fixed this in 2.10.x of Vite Plugin Solid but Start hasn't been updated to it. Thanks for pointing this out.
Sorry, something went wrong.
This has been fixed in 7ae0541
No branches or pull requests
Duplicates
Latest version
Current behavior 😯
Extending solid config has required fields that should be optional.
Expected behavior 🤔
Should not error since these fields have default values. Looking at
vite-plugin-solid
it seems like these are optional there.Steps to reproduce 🕹
https://stackblitz.com/edit/github-e58cde-3el8ng?file=package.json
Steps:
app.config.ts
with some babel settingsContext 🔦
Encountered when trying to use config from nksaraf/vinxi#204 (comment)
Your environment 🌎
No response
The text was updated successfully, but these errors were encountered: