Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?]: Dev server fails to start when installing with new pnpm lockfiles #1465

Closed
2 tasks done
HansT01 opened this issue May 2, 2024 · 3 comments
Closed
2 tasks done
Labels
bug Something isn't working

Comments

@HansT01
Copy link
Contributor

HansT01 commented May 2, 2024

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

Dev server fails with the following error:

vinxi v0.3.11
Error [ERR_MODULE_NOT_FOUND]: Cannot find module '<PROJECT_PATH>\node_modules\.pnpm\@[email protected][email protected][email protected][email protected]_@[email protected]_iore_xyc5haahokuf7onqczdjnghlzm\node_modules\@vinxi\server-functions\plugin' imported from <PROJECT_PATH>\node_modules\.pnpm\@[email protected][email protected][email protected][email protected]_@[email protected]_iore_xyc5haahokuf7onqczdjnghlzm\node_modules\@solidjs\start\config\index.js
Did you mean to import "@vinxi/server-functions/plugin.js"?
    at finalizeResolution (node:internal/modules/esm/resolve:263:11)
    at moduleResolve (node:internal/modules/esm/resolve:908:10)
    at defaultResolve (node:internal/modules/esm/resolve:1131:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:390:12)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:359:25)
    at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:234:38)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:85:39)
    at link (node:internal/modules/esm/module_job:84:36) {
  code: 'ERR_MODULE_NOT_FOUND',
  url: '<PROJECT_PATH>/node_modules/.pnpm/@[email protected][email protected][email protected][email protected]_@[email protected]_iore_xyc5haahokuf7onqczdjnghlzm/node_modules/@vinxi/server-functions/plugin'
}
vinxi starting dev server
Terminate batch job (Y/N)?

An app.config.timestamp_<TIMESTAMP>.js file is created as a side effect.

image

Expected behavior 🤔

No errors

Steps to reproduce 🕹

Steps:

  1. pnpm add -g pnpm@latest
  2. pnpm create solid
  3. choose any template
  4. navigate to project
  5. pnpm install
  6. pnpm dev

Context 🔦

I had a repository with an older lockfile that got updated when I installed anything. The newer lockfile errors while the older one does not. In this example I've just updated the solidjs package from 1.8.16 to 1.8.17. See the lockfile diff here:

HansT01/stock-evaluator@7f459eb#r141586858

Issue could be related #1460

Your environment 🌎

Windows 10 OS
pnpm 9.0.6
node 21.7.3
@HansT01 HansT01 added the bug Something isn't working label May 2, 2024
@ryansolid
Copy link
Member

ryansolid commented May 2, 2024

Hmm... I wonder if it is windows related. I used this an opportunity to upgrade to node 20 and update to the latest pnpm. And I did not hit the same issues. I removed the lockfile and the node_modules and tried again and still good.

I might need help from others to reproduce this.

EDIT: Ok while I couldn't reproduce your issue in a fresh project updating to pnpm 9 completely messed up local dev in the start repo. Really weird deduping resolution etc.. even after clean installs. I think it might just be buggy. I went back to 8 so I could just get development done.

@HansT01
Copy link
Contributor Author

HansT01 commented May 3, 2024

Upgrading from node v21.7.3 to 22 seems to fix the issue for me. Downgrading to node 20 also seems to fix the issue.

@HansT01
Copy link
Contributor Author

HansT01 commented May 3, 2024

Issue probably isn't worth investigating further.

@HansT01 HansT01 closed this as completed May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants