[Bug?]: "Zero-config" Netlify provider does not load a Netlify preset automatically

[serhalp]

Duplicates

• I have searched the existing issues

Latest version

• I have tested the latest version

Current behavior 😯

When deploying to Netlify and when using the Netlify CLI, the node-server Nitro preset is used by default.

Expected behavior 🤔

The netlify (or netlify_edge) preset should be loaded by default, when not otherwise specified.

Steps to reproduce 🕹

Steps:

1. pnpm create solid
2. pnpm add --global netlify-cli
3. netlify dev or netlify serve or deploy to Netlify

Context 🔦

Netlify is a Nitro "zero-config provider".

Also, a Netlify preset is required to use any server-side functionality (SSR, etc.) at runtime.

My best guess is that this vinxi logic results in always explicitly passing a preset to Nitro, so all its preset resolution logic ends up being useless as it is overridden by the explicit preset passed in? I don't know if that's quite right though.

If that's true, it would mean all the other zero-config providers aren't zero config either. I haven't verified that.

Your environment 🌎

macOS 14.5, [email protected], [email protected], @solidjs/[email protected]

[ryansolid]

I think you are right.. I noticed there was a bug here but hadn't had the chance to dig into it. Thank you.

[serhalp]

👋🏼 Hey Ryan, do you think I should open an issue over in the vinxi repo?

[ryansolid]

I actually already got on it: nksaraf/vinxi#325

[ryansolid]

Ok fix is in. Just tested and seems good. Thanks for finding the problem.