Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bump script #1027

Merged
merged 13 commits into from
Aug 29, 2023
Merged

Update bump script #1027

merged 13 commits into from
Aug 29, 2023

Conversation

edivados
Copy link
Contributor

@edivados edivados commented Aug 23, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • infrastructure changes
  • Other... Please describe:

What is the current behavior?

Currently the bump script does not:

  • update adapter versions of examples
  • update version of packages declared as dev dependency
  • update solid-js version of solid-start, docs and test template
  • update lock file

This can lead to the following:

  • Builds not working inside the repo because of multiple solid-js versions
  • GitHub tests failing because of outdated lock file (Forgetting to update lock file after version bump)

What is the new behavior?

Covering all of the above mentioned.

Other information

@edivados edivados marked this pull request as ready for review August 29, 2023 17:31
@ryansolid ryansolid merged commit 2e3fd35 into solidjs:main Aug 29, 2023
9 checks passed
@edivados edivados deleted the bump-bump branch August 29, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants