Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: islands not hydrating when build on windows #1046

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

edivados
Copy link
Contributor

@edivados edivados commented Sep 3, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • infrastructure changes
  • Other... Please describe:

What is the current behavior?

One path is not being normalized breaking island hydration when build on windows.

What is the new behavior?

Islands working when build on windows.

Other information

@ryansolid ryansolid merged commit 043577a into solidjs:main Sep 6, 2023
9 checks passed
@ryansolid
Copy link
Member

Thanks

@edivados edivados deleted the islands-windows branch September 10, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants