Polyfill process.env on Netlify edge #1108
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The only way to read environment variables at runtime on Netlify edge is via their
Netlify.env.get
function. As well as being Netlify-specific, this is awkward to use from TypeScript as it doesn't seem to have correct type declarations.What is the new behavior?
Environment variables can be read via
process.env
.This matches the default behavior on Vercel's edge, and the Next.js middleware on Netlify edge.
Other information
I haven't included a test in this PR, but I made a test site in a separate repo (https://github.com/iainmerrick/solid-start-edge-test/). Here's a route that reads
process.env
(using this PR):