Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update drizzle dependencies and config #1558

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Update drizzle dependencies and config #1558

merged 4 commits into from
Jun 25, 2024

Conversation

thednp
Copy link
Contributor

@thednp thednp commented Jun 23, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • infrastructure changes
  • Other... Please describe:

Upated drizzle to latest.

What is the current behavior?

When users install this example, updating to latest drizzle will show some warning about the config that requires a new "dialect" property.

What is the new behavior?

The new behavior isn't changed, but we want to make sure this won't brake in future iterations.

Other information

Copy link

changeset-bot bot commented Jun 23, 2024

⚠️ No Changeset found

Latest commit: 1c6030e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ryansolid ryansolid merged commit 6352aa0 into solidjs:main Jun 25, 2024
1 check failed
@thednp thednp deleted the patch-1 branch June 26, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants