Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on the Definition and Implementation of Deleterious Score in Your Paper and Code #35

Open
yangzhao1230 opened this issue Jan 3, 2025 · 0 comments

Comments

@yangzhao1230
Copy link

In your paper, the deleterious score is defined as the difference in log-likelihood. However, in your code, it seems that the implementation is based on the difference of logits (noting that the logits do not directly represent probabilities).

While this difference does not affect the ranking of scores, and therefore metrics like AUROC remain consistent, I noticed a discrepancy when analyzing the peak values of the deleterious score. This was highlighted in the updated version of Extended Fig. 4 in your paper. This raises a key point of confusion for me: since the score does not represent actual probabilities, how should we interpret or analyze the specific definition and implications of this score in practical contexts?

Thank you in advance for your clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant