Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yang] interface yang model is missing mac_addr key #14253

Open
assafho opened this issue Mar 15, 2023 · 4 comments · May be fixed by #20968
Open

[yang] interface yang model is missing mac_addr key #14253

assafho opened this issue Mar 15, 2023 · 4 comments · May be fixed by #20968
Assignees
Labels
Issue for 202205 Issue for 202211 Triaged this issue has been triaged YANG YANG model related changes

Comments

@assafho
Copy link

assafho commented Mar 15, 2023

Description

interface yang model is missing the mac_addr key.
RIF mac address config was defined at sonic-net/sonic-swss#814, however,
it is not defined in https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/yang-models/sonic-interface.yang

Steps to reproduce the issue:

Describe the results you received:
interface yang model is missing mac_addr key

Describe the results you expected:
interface yang model should include mac_addr key

Output of show version:

(paste your output here)

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):

I suggest to add the following to sonic-interface.yang:

import ietf-yang-types {

prefix yang;

}

...
...

leaf mac_addr {

type yang:mac-address;

}

@dgsudharsan dgsudharsan added the YANG YANG model related changes label Mar 15, 2023
@zhangyanzhao
Copy link
Collaborator

@prsunny can you please help to take a look at this issue? You approved the PR in 2019. Thanks.

@zhangyanzhao zhangyanzhao added the Triaged this issue has been triaged label Apr 6, 2023
@dgsudharsan
Copy link
Collaborator

@prsunny Any update on this?

@liat-grozovik
Copy link
Collaborator

any update on this issue?

@bradh352 bradh352 linked a pull request Nov 29, 2024 that will close this issue
10 tasks
@bradh352
Copy link
Contributor

I ran into this as well, submitted PR #20968

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue for 202205 Issue for 202211 Triaged this issue has been triaged YANG YANG model related changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants