Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cropped tab height #10

Open
illegalargumentexc opened this issue Mar 10, 2023 · 4 comments
Open

cropped tab height #10

illegalargumentexc opened this issue Mar 10, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@illegalargumentexc
Copy link

illegalargumentexc commented Mar 10, 2023

the tab height is cropped, i managed to fix it by changing the tab-newtab-button max-height in tabs.css to a higher value
idk how to submit fixes or bugs i'm new to contributing
Screen Shot 2023-03-10 at 7 11 13 PM

@soup-bowl
Copy link
Owner

It's best to rule out a setup bug before committing changes, as what might fix for one, might break for others. Cautious as I'm using the theme on Chicago95 currently without tab height issues. Looks like your screen is high density?

If you can drop some details about your environment (Firefox version, Operating System, theme, resolution) when I've got some time I can replicate it.

@illegalargumentexc
Copy link
Author

I tried it on both my main macos host and on my voidlinux vm, it persisted in both cases, even with DPI changes

Host details:

macOS High Sierra 10.13.6
Mac Pro 5,1 (Early 2009)
GPU: ATI Radeon HD 4870
CPU: 2 x Intel Xeon E5520
Memory: 20GB DDR3
DE: Aqua
WM: Rectangle
Resolution: 1920x1200
Browser: Librewolf 110.0-1

VM details:

OS: Void Linux
Host: VirtualBox
DE: xfce 4.18
WM: xfwm 4.18
Theme: Chicago95
Resolution: 1920x1200
Firefox Version: Firefox ESR 102.3.0

It could be a hardware issue with my GPU failing to render it, although opening more tabs and making the tab navigation buttons appear seems to fix it for as long as there are that many tabs open

@soup-bowl
Copy link
Owner

I tried it on both my main macos host [..]

FYI macOS isn't currently supported - the theme has a hard dependency on a present menubar, and there will be spacing issues due to the lack of one.

OS: Void Linux
Host: VirtualBox
DE: xfce 4.18
WM: xfwm 4.18
Theme: Chicago95
Resolution: 1920x1200
Firefox Version: Firefox ESR 102.3.0

Thanks for dropping your setup details - I'll try replicating it.

@soup-bowl
Copy link
Owner

soup-bowl commented Mar 15, 2023

Does it mysteriously disappear when you open customise, but once leaving it returns back to a gap? If so, I believe I've replicated the problem on my ESR copy. Appears fine on main build.

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants