Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Avenger Backlog Notifications #1070

Closed
wants to merge 16 commits into from

Conversation

GabrielCWT
Copy link
Contributor

@GabrielCWT GabrielCWT commented Feb 24, 2024

  • Implement dedicated function for getting ungraded submissions. It fetches only the bare minimum (assessment_title, student_name, submission_id and course_id)
  • Refactor avenger backlog email template to use new function
  • Refactor cron job to use new function
  • Include status: submitted in test seed submissions
  • Refactor tests to use the dedicated function

Closes #1040

Closes #1032
Closes #939

A dedicated function for Avenger backlog email notifications, it only fetches necessities (assessment_title, student_name and submission_id)
@GabrielCWT GabrielCWT linked an issue Feb 24, 2024 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Feb 24, 2024

Coverage Status

coverage: 94.998% (+0.006%) from 94.992%
when pulling 2095250 on GabrielCWT:fix/notifications
into 11154a6 on source-academy:master.

@GabrielCWT GabrielCWT marked this pull request as draft February 25, 2024 01:13
@GabrielCWT
Copy link
Contributor Author

GabrielCWT commented Feb 25, 2024

Changed back to draft as I would like to update notification links as well. @RichDom2185 any ideas on how would I get frontend url, is there an env variable I can use? Also I don't think there is an unsubscribe link as of yet

Edit: Probably can use cors_endpoints for frontend url.

@GabrielCWT
Copy link
Contributor Author

GabrielCWT commented Feb 25, 2024

TODO:

  • Update unsubscribe link
  • Update url builder to use frontend url (Currently hardcoded to sourceacademy)

@GabrielCWT GabrielCWT closed this Aug 23, 2024
@GabrielCWT GabrielCWT deleted the fix/notifications branch August 23, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve email generation logic Update notification links Fix Avenger backlog email generation
2 participants