Add SAML SP metadata endpoints and flow #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Hacky fallback because SAML does not require a code to be sent in the authentication flow.
FIXME was causing `mix credo` to fail.
chownces
force-pushed
the
add-saml-metadata
branch
from
b84ea88 to
4f994a8
Compare
7 tasks
chownces
reviewed
May 12, 2024
| conn | ||
| |> put_resp_cookie("jwts", encoded_tokens, | ||
| domain: "cadet.ap", | ||
| http_only: false |
There was a problem hiding this comment.
Add secure: false for use with local http frontend domain during testing.
chownces
reviewed
May 12, 2024
chownces
reviewed
May 12, 2024
RichDom2185
changed the title
|
Corresponding frontend PR: source-academy/frontend#2994 |
RichDom2185
commented
May 12, 2024
chownces
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets up SAML and exposes some endpoints for SAML auth flow, following
samly's documentation.