Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SAML authentication provider #2719

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Support SAML authentication provider #2719

merged 3 commits into from
Dec 13, 2023

Conversation

RichDom2185
Copy link
Member

@RichDom2185 RichDom2185 commented Dec 8, 2023 •
edited
Loading

Description

Adds support for SAML/SSO login flow (which is primarily handled in the backend as a SP).

Relevant backend PR: source-academy/backend#990

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

The login flow works expectedly.

Checklist

  • I have tested this code
  • I have updated the documentation

@RichDom2185 RichDom2185 requested a review from chownces December 8, 2023 13:28
@RichDom2185 RichDom2185 self-assigned this Dec 8, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7141948357

  • 9 of 16 (56.25%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 37.186%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commons/utils/AuthHelper.ts 0 2 0.0%
src/commons/utils/RequestHelper.tsx 2 4 50.0%
src/commons/utils/Constants.ts 4 7 57.14%
Totals Coverage Status
Change from base Build 7073633257: 0.01%
Covered Lines: 5728
Relevant Lines: 14465
💛 - Coveralls

chownces
chownces approved these changes Dec 12, 2023
View reviewed changes
src/commons/utils/Constants.ts Show resolved Hide resolved
@RichDom2185 RichDom2185 marked this pull request as ready for review December 13, 2023 02:28
@RichDom2185 RichDom2185 merged commit af2d15f into source-academy:master Dec 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chownces chownces chownces approved these changes

Assignees

@RichDom2185 RichDom2185

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RichDom2185 @coveralls @chownces