From 24c0aa3d3f4b721036e76e6bcbed392713dec6ed Mon Sep 17 00:00:00 2001
From: sayomaki <sayomayomaki@gmail.com>
Date: Mon, 6 May 2024 18:05:18 +0800
Subject: [PATCH] Miscellaneous repository updates (#1704)

* Fix pull request template and ensure that it works

* Update CI to test documentation compilation

* Reduce the pre-push hook duration to just check formatting and linting

* Remove pre-commit hook as checks are superseded by pre-push hook

* Revert "Update CI to test documentation compilation"

This reverts commit 1bbae4511893d373907ca4439a66d5b30f03bc15.
---
 .github/pull_request_template.md              | 22 +++++++++++++
 .husky/pre-commit                             |  4 ---
 .husky/pre-push                               |  2 +-
 .../pull_request_template.md                  | 31 -------------------
 4 files changed, 23 insertions(+), 36 deletions(-)
 create mode 100644 .github/pull_request_template.md
 delete mode 100755 .husky/pre-commit
 delete mode 100644 src/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md

diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
new file mode 100644
index 000000000..d48e8428d
--- /dev/null
+++ b/.github/pull_request_template.md
@@ -0,0 +1,22 @@
+### Description
+
+<!-- Please include a summary of the changes proposed, and include relevant motivation and context. List issues/pull requests that are related for this change (if any). -->
+
+### Type of change
+
+- [ ] Bug fix (non-breaking change which fixes an issue)
+- [ ] New feature (non-breaking change which adds functionality)
+- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
+- [ ] Documentation update
+- [ ] Code quality improvements
+
+### How to test
+
+<!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. -->
+
+### Checklist
+
+<!-- Please delete options that are not relevant. -->
+
+- [ ] I have tested this code
+- [ ] I have updated the documentation
diff --git a/.husky/pre-commit b/.husky/pre-commit
deleted file mode 100755
index f67d43ffd..000000000
--- a/.husky/pre-commit
+++ /dev/null
@@ -1,4 +0,0 @@
-#!/bin/sh
-. "$(dirname "$0")/_/husky.sh"
-
-yarn eslint --fix && yarn format && yarn eslint
\ No newline at end of file
diff --git a/.husky/pre-push b/.husky/pre-push
index 9e5ab0cee..7263f16f9 100755
--- a/.husky/pre-push
+++ b/.husky/pre-push
@@ -1,4 +1,4 @@
 #!/bin/sh
 . "$(dirname "$0")/_/husky.sh"
 
-yarn jsdoc && yarn autocomplete && yarn format:ci && yarn eslint && yarn test
+yarn format:ci && yarn eslint
diff --git a/src/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md b/src/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md
deleted file mode 100644
index 508a3bc5e..000000000
--- a/src/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md
+++ /dev/null
@@ -1,31 +0,0 @@
-<!--
-Thank you for contributing to Source Academy!
-The template below was made to help both you and the reviewers understand
-your changes. Please fill it up to the best of your ability.
-(These are comments, they won't be shown in the "preview")
--->
-
-## Context
-<!-- Please link to a Github issue (type `#` to autocomplete issue) -->
-<!-- Or provide a brief explanation about the problem -->
-
-## Implementation
-<!-- Explain how your solution solves the problem -->
-<!-- If it affects UI, an image or gif is greatly encouraged. -->
-
-## Source Documentation
-<!--
-If you're making a PR which changes the behavior of js-lang
-please include a link to the relevant section of the updated source documentation here
--->
-
-## Other Information
-<!--
-This section is optional, it's for stuff like:
-- Any questions you may have
-- Any assistance you need
-- Any tasks that are incomplete
-- Letting us know that you're new to this (so we know how much to help out)
-- Random gifs and emojis
--->
-