Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make model and repository customizable #121

Open
mrbatista opened this issue May 17, 2024 · 5 comments · May be fixed by #124
Open

Make model and repository customizable #121

mrbatista opened this issue May 17, 2024 · 5 comments · May be fixed by #124
Assignees
@yeshamavani

Comments

@mrbatista
Copy link

mrbatista commented May 17, 2024 •
edited
Loading

When update to latest version is not possible to use custom repository.
download a simple repo that reproduce that problem

Make AuditLog model and AuditLogRepository customizable.
The latest version add some dependencies and logic that not make library generic:

  • @sourcefuse/core dependency is out of scope of this library
  • @loopback/sequelize dependency is out of scope of this library
  • export a AuditLog model with tenantId property required
@yeshamavani
Copy link
Contributor

@Tyagi-Sunny please have a look

@Tyagi-Sunny
Copy link
Contributor

ok

@mrbatista
Copy link
Author

mrbatista commented Jun 10, 2024 •
edited
Loading

@Tyagi-Sunny, @Surbhi-sharma1 ping

@yeshamavani
Copy link
Contributor

@Tyagi-Sunny, @Surbhi-sharma1 ping

Hello @mrbatista I will have a look at this and let you know

@mrbatista
Copy link
Author

@yeshamavani my 2cent:

  • Migrate library as a component
  • Define default AuditLog class
  • Define default AutidTenantLog class
  • Options to configure component to bind to default AuditLog or custom

yeshamavani added a commit that referenced this issue Jun 13, 2024
@yeshamavani
fix(core): make model and resposiory customizable
37ea818 
now user can use the default as well as their custom respository

GH-121
@yeshamavani yeshamavani linked a pull request Jun 13, 2024 that will close this issue
Open
10 tasks
yeshamavani added a commit that referenced this issue Jun 19, 2024
@yeshamavani
fix(core): readme in docs folder also updated
c075f96 
both the readme have to be in sync

GH-121
yeshamavani added a commit that referenced this issue Nov 5, 2024
@yeshamavani
Merge branch 'master' into GH-121
4088cc8
yeshamavani added a commit that referenced this issue Nov 6, 2024
@yeshamavani
feat(mixin): make model and repository customizable
73e964b 
update the docs

GH-121
@yeshamavani yeshamavani self-assigned this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yeshamavani yeshamavani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(core): make model and respository customizable sourcefuse/loopback4-audit-log
4 participants
@mrbatista @yeshamavani @Surbhi-sharma1 @Tyagi-Sunny