You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As far as I see, the problem is that the call to tls.DialWithDialer results in an error if the certificate already expired, so when we reach conclude(), the very first thing we do is check for errors and returning, resulting in never being able to get the expiration date.
While using the tls check, when the certificate is already expired, I expected to see the expired date just as shown in the
tls.go
check:As far as I see, the problem is that the call to
tls.DialWithDialer
results in an error if the certificate already expired, so when we reachconclude()
, the very first thing we do is check for errors and returning, resulting in never being able to get the expiration date.Also, even if I comment the previous validation, the connection used for
DialWithDialer
will benil
and we are unable to get any expiry date from it.I tried using
InsecureSkipVerify = true
inside the tlsConfig but then that breaks some other useful checks, like verifying the root CA.I'm new to golang but if anyone knows how to fix this then I can submit a PR for review.
The text was updated successfully, but these errors were encountered: