Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Make "view diff on Sourcegraph" navigate to the specific file on compare page #47882

Open
taras-yemets opened this issue Feb 20, 2023 · 0 comments
Open

Make "view diff on Sourcegraph" navigate to the specific file on compare page #47882

taras-yemets opened this issue Feb 20, 2023 · 0 comments
Labels
team/code-search Issues owned by the code search team

Comments

@taras-yemets
Copy link
Contributor

taras-yemets commented Feb 20, 2023 •
edited by sourcegraph-bot-2
Loading

Currently "view on Sourcegraph" link (next to the file name) on the GitHub pull request (compare) pages navigate to the top of the corresponding compare page on Sourcegraph. It's not very useful especially in case of large diffs.

Internal feedback:

I often click the sourcegraph github extension button on a file while reviewing a PR and hope it will open that file at that specific branch/commit in sourcegraph. the behaviour is actually to open the diff. the button even says “view file diff on sourcegraph”, but opens the full file diff (which is basically unusable on large PRs).

Screen.Recording.2023-02-20.at.09.22.10.mov

/cc @felixfbecker
@taras-yemets taras-yemets added browser-extension team/code-exploration Issues owned by the Code Exploration team labels Feb 20, 2023
@fkling fkling added team/code-search Issues owned by the code search team imported Label for marking issues that have been imported from another team and removed team/code-exploration Issues owned by the Code Exploration team labels Feb 22, 2024
@mmanela mmanela added the Migrated label May 6, 2024 — with Linear
@eseliger eseliger removed the Migrated label May 21, 2024
@eseliger eseliger changed the title Make "view diff on Sourcegraph" navigate to the specific file on compare page Make "view diff on Sourcegraph" navigate to the specific file on compare page May 21, 2024
@camdencheek camdencheek removed imported Label for marking issues that have been imported from another team browser-extension labels May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
team/code-search Issues owned by the code search team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@fkling @mmanela @camdencheek @eseliger @taras-yemets