Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depricate: go-libp2p is removing database-backed peerstore (pstoreds) #1902

Closed
shahzadlone opened this issue Sep 25, 2023 · 2 comments · Fixed by #2888
Closed

Depricate: go-libp2p is removing database-backed peerstore (pstoreds) #1902

shahzadlone opened this issue Sep 25, 2023 · 2 comments · Fixed by #2888
Labels
dependencies Related to dependencies deprecate Indicates something is deprecated. priority/high

Comments

@shahzadlone
Copy link
Member

Note:

// Deprecated: The database-backed peerstore will be removed from go-libp2p in the future.
// Use the memory peerstore (pstoremem) instead.
// For more details see https://github.com/libp2p/go-libp2p/issues/2329
// and https://github.com/libp2p/go-libp2p/issues/2355.

In net/node.go we use "github.com/libp2p/go-libp2p/p2p/host/peerstore/pstoreds" that creates our peerstore from the underlying defra rootstore with the appropriate prefix. However now if we are forced to use pstoremem

@shahzadlone shahzadlone added dependencies Related to dependencies priority/high deprecate Indicates something is deprecated. labels Sep 25, 2023
@shahzadlone shahzadlone added this to the DefraDB v0.8 milestone Sep 25, 2023
@nasdf
Copy link
Member

nasdf commented Oct 4, 2023

Related #1680

@shahzadlone
Copy link
Member Author

#1889 will suppress this linter warning but leaving a todo in source-code as the dependencies are piling up.

@fredcarle fredcarle removed this from the DefraDB v0.8 milestone Aug 23, 2024
@nasdf nasdf closed this as completed in 9a228d2 Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related to dependencies deprecate Indicates something is deprecated. priority/high
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants