Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binary install / checksum attributes documented aren't correct #127

Open
atrull opened this issue Apr 5, 2016 · 5 comments
Open

binary install / checksum attributes documented aren't correct #127

atrull opened this issue Apr 5, 2016 · 5 comments
Labels
Bug Something isn't working Maintenance Maintenance issues such as failing builds Priority: Medium Will bring visible benefit to the project

Comments

@atrull
Copy link

atrull commented Apr 5, 2016

Dear nodejs cookbook devs..

following your documented attributes (the defaults) it turns out you've got a more complex, non-valid documented setup.

if you follow it with the example it indicates:

node.default['nodejs']['binary']['checksum']['linux_x64'] = '656d8bff06cc5e108b83176f81de7e1eb16392ae0958ec4a7bca2a3a309333a1'

resulting in..

Option checksum's value {"linux_x64"=>"656d8bff06cc5e108b83176f81de7e1eb16392ae0958ec4a7bca2a3a309333a1", "linux_x86"=>"8fa2d952556c8b5aa37c077e2735c972c522510facaa4df76d4244be88f4dc0f", "linux_arm-pi"=>"52a0f6ed9c0be1ea5f79de6527c481c1b803edbea6413a4fdc65a45ad401565d"} does not match regular expression /^[a-zA-Z0-9]{64}$/

The only valid option for the url method is just node.default['nodejs']['binary']['checksum'] :-)

Not a killer bug or anything but would annoy someone less patient.

Cheers

Alex

@rojomisin
Copy link

ran into this too today, the quick fix for me to install a binary from a specific url on centos
change checksum to checksum["linux_#{arch}"]

ark archive_name do
  url nodejs_bin_url
  version node['nodejs']['version']
  checksum checksum["linux_#{arch}"]
  has_binaries binaries
  action :install
end

will debug more and send a pr later

@stephenreid
Copy link

I read this as an example (you should check checksums against an authority and they would vary based off of OS/Version)

As an additional note, the version must be specific for the binary, you can't use typical rubygems version strings.

orangejulius added a commit to pelias-deprecated/vagrant that referenced this issue Aug 12, 2016
There are some [issues](sous-chefs/nodejs#127)
in the nodejs recipe repo that seem to indicate others have had problems
as well.
@wesleung
Copy link

Bump on this issue as I no longer directly use the cookbook, instead copied and commented out the checksum.

@github-actions
Copy link

Marking stale due to inactivity. Remove stale label or comment or this will be closed in 7 days. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help! Thanks, Sous-Chefs.

@github-actions github-actions bot added the Stale label Sep 30, 2020
@xorimabot xorimabot removed the Stale label Sep 30, 2020
@MarkGibbons
Copy link
Member

The checksum use needs a lot of work.

@MarkGibbons MarkGibbons added Bug Something isn't working Maintenance Maintenance issues such as failing builds Priority: Medium Will bring visible benefit to the project labels Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Maintenance Maintenance issues such as failing builds Priority: Medium Will bring visible benefit to the project
Projects
None yet
Development

No branches or pull requests

6 participants