Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Content.PatreonParser to use net8.0 TargetFramework #33559

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Update Content.PatreonParser to use net8.0 TargetFramework #33559

merged 1 commit into from
Nov 28, 2024
+1 −1

Conversation

CrafterKolyan
Copy link
Contributor

@CrafterKolyan CrafterKolyan commented Nov 25, 2024 •
edited
Loading

About the PR

Updates Content.PatreonParser project to use net8.0 framework.
Allows to use .NET SDK 8.0.404 without any errors

Technical details

Build succeeds with usage of latest versions of .NET SDK and .NET Desktop Runtime

Requirements

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS Denotes a PR that changes 0-9 lines. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. and removed size/XS Denotes a PR that changes 0-9 lines. labels Nov 25, 2024
@CrafterKolyan CrafterKolyan changed the title Update Content.PatreonParser to use net8.0 targetframework Update Content.PatreonParser to use net8.0 TargetFramework Nov 25, 2024
@metalgearsloth
Copy link
Contributor

Why not 9?

@CrafterKolyan
Copy link
Contributor Author

I haven't tested it for 9.0. I thought the project is not ready for net9.0 based on this space-wizards/RobustToolbox#5527 . I guess that means that it's better to upgrade this to net8.0 for now.

@ScarKy0 ScarKy0 added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: Cleanup Type: Code clean-up, without being a full refactor or feature D2: Medium Difficulty: A good amount of codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Core Tech Area: Underlying core tech for the game and the Github repository. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 26, 2024
@PJB3005 PJB3005 merged commit 4a21ed8 into space-wizards:master Nov 28, 2024
14 checks passed
@CrafterKolyan CrafterKolyan deleted the patch-2 branch November 30, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A: Core Tech Area: Underlying core tech for the game and the Github repository. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D2: Medium Difficulty: A good amount of codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Needs Review Status: Requires additional reviews before being fully accepted T: Cleanup Type: Code clean-up, without being a full refactor or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CrafterKolyan @metalgearsloth @PJB3005 @ScarKy0