Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Cubeviz: Get glue-astronomy translators to work with latest Spectrum1D and/or NDCube #588

Closed
javerbukh opened this issue May 5, 2021 · 2 comments
Labels
cubeviz feature Feature request

Comments

@javerbukh
Copy link
Contributor

Description

Get glue-astronomy translators to work with latest Spectrum1D and/or NDCube.

Related to PR #547

Additional context

@javerbukh javerbukh added cubeviz feature Feature request labels May 5, 2021
@rosteen
Copy link
Collaborator

rosteen commented Oct 14, 2021

Note that I did some work already in glue-astronomy to update the Spectrum1D translator, but @orifox found that the current iteration only works if a full WCS has been specified for the Spectrum1D, not if you instantiate the Spectrum1D by giving it only a spectral_axis. There are (at least) two problems due to the fact that in this case, Spectrum1D creates a SpectralGWCS lookup table based on the spectral_axis on initialization:

  1. The glue-astronomy translator currently uses wcs.swap_axes, which doesn't exist for a GWCS.
  2. If the above is remedied (I tried adding an isinstance check), glue core then throws an error where it looks for axis names in the Data object coords, and fails on an IndexError because it's looking for three axis names and there is only one axis in the GWCS.

EDIT: It's unclear to me if this is somehow caused by needing to convert into a SpectralCube and would thus be resolved by #547. Fingers crossed.

@rosteen
Copy link
Collaborator

rosteen commented Dec 26, 2023

Looks like this should have been closed a while ago.

@rosteen rosteen closed this as completed Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cubeviz feature Feature request
Projects
None yet
Development

No branches or pull requests

2 participants