Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plotting commands #323

Open
Witchblade101 opened this issue Sep 14, 2023 · 2 comments
Open

Fix plotting commands #323

Witchblade101 opened this issue Sep 14, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@Witchblade101
Copy link
Collaborator

@tddesjardins pointed out on Slack that fillstyle='full' doesn't appear to work anymore.

The plotted apertures in the readme.md and other documentation show the defaults of aperture.plot(), which are filled cyan shapes. This appears to now be overridden almost everywhere by empty shapes with different colored lines for each aperture (see siaf.plot_main_apertures(), e.g.)

I also notice that in the default HST plotting example it appears that some ACS apertures are getting filled, but are at a different scale or on a different coordinate system.

From Readme.md:
image

What you currently get if you actually run that code:
image

First step when I have the time: Find the PR or commit when this stopped working.

@Witchblade101 Witchblade101 added the bug Something isn't working label Sep 14, 2023
@Witchblade101 Witchblade101 self-assigned this Sep 14, 2023
@Witchblade101
Copy link
Collaborator Author

Tested old versions starting with 0.10.0. Plotting breaks in pysiaf starting with 0.13.0. Before that it behaves as expected.

@Witchblade101
Copy link
Collaborator Author

@mfixstsci This strongly points to my initial suspicion that the problem relates to the changes made with PR #177 and PR #185 (Since that was the only time I remember anyone touching the plot functions...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant