Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect maintainer package list comment #55

Open
adamjstewart opened this issue Sep 25, 2021 · 1 comment
Open

Incorrect maintainer package list comment #55

adamjstewart opened this issue Sep 25, 2021 · 1 comment

Comments

@adamjstewart
Copy link
Member

On spack/spack#26252, I see:

@marcmengel can you review this PR?

This PR modifies the following package(s), for which you are listed as a maintainer:

* py-setuptools-scm-git-archive
* py-tomopy

However, @marcmengel is not the maintainer of py-tomopy, I am:

$ spack maintainers py-tomopy
adamjstewart

Spack-bot correctly requests my review and pings @marcmengel, but I think the comment should only list py-setuptools-scm-git-archive. This is a bit harder because it would require us to keep a dict of packages and maintainers and only ping those whom we can't request a review for.

@haampie
Copy link
Member

haampie commented May 4, 2024

Apparently this is a very hard task!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants