Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input labels into TransactionDiagram along with transaction notes #1506

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

canselcik
Copy link

Will add screenshots later if needed. I don't imagine any downsides to it and it feels like something that's missing.

@craigraw
Copy link
Collaborator

Not sure I follow.

  • The input label is displayed on the input already, displaying it on the tooltip as well is redundant (see getInputDescription method)
  • The name of the transaction is already displayed as the tab name.

@canselcik
Copy link
Author

canselcik commented Sep 24, 2024

@craigraw Thank you for the reply, I appreciate it.

The input label is displayed on the input already, displaying it on the tooltip as well is redundant (see getInputDescription method)

The input label is displayed in a shortened way on the left side. If I have a long note in the label, it might as well be not there.

The name of the transaction is already displayed as the tab name.

This hasn't been my experience, I see just the first six characters of the hash in brackets in the tab title.

Here is the screenshot I promised earlier. Let me know what you think.
example

@craigraw
Copy link
Collaborator

The input label is displayed in a shortened way on the left side. If I have a long note in the label, it might as well be not there.

Ok, that's reasonable. I remember someone else mentioning this as well. Can we keep the same formatting though - no space after the if. I'm aware it's non-standard :)

This hasn't been my experience, I see just the first six characters of the hash in brackets in the tab title.

This occurs only if there is no name. For reference, see

if(tabName == null || tabName.isEmpty()) {
tabName = "[" + transaction.getTxId().toString().substring(0, 6) + "]";
}

But I understand what you mean - when opening transactions with existing labels, the tab name did not take on the label. This has been fixed in 1bbc586.

@canselcik
Copy link
Author

No worries, happy to keep the if the non-standard way you like. :)

I appreciate the quick fix with 1bbc586, I will also rebase this commit and revert the reformatted if.

Another thing that I think would be great to have in Sparrow would be an easy to navigate linear utxo history.
It can even be as simple as a ListView but being able to see all the transactions a utxo has been involved with, with their dates and transaction labels would be very helpful.

I would try to add this myself as well but I am not familiar with the codebase enough to put together a proof of concept real quick.

@craigraw
Copy link
Collaborator

craigraw commented Oct 7, 2024

Just following up here? - happy to just make the changes myself, no problem. Mostly just reverting HeadersController and headers.fxml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants