-
-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New version need properties optional in previous package version #1813
Comments
I suggest to update your own config file when upgrading to a new major, so they keep in sync. https://github.com/spatie/laravel-backup/blob/main/config/backup.php |
Hi @Nielsvanpach, This isn't really an "issue"—it's more of a suggestion. As you know it, in Laravel 11, when developers don't need to change the default values in a config file, it's not necessary to include those defaults in the project's config. In Laravel Backup 8 with Laravel 11, if I wanted to modify just the
However, in Laravel Backup 9 with Laravel 11, to modify the
Even though the rest of these properties are just defaults from the original My suggestion is to allow the |
With version
9.0.0
a lot of config values become mandatory in config file. In my case in previous version8.8.1
I didn't need these properties :Should this be a good idea to merge arrays with default config inside
Config::fromArray
insrc/Config/Config.php
file on line24
:This is probably a bit tricky, but the idea to merge missing elements from default config into the current one should probably be the solution ?
The text was updated successfully, but these errors were encountered: