Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle foreign exported links in the case of foreign diff specs. #1599

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Handle foreign exported links in the case of foreign diff specs. #1599

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions bikeshed/refs/ReferenceManager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,6 +427,11 @@ def getRef(self, linkType, text, spec=None, status=None, statusHint=None, linkFo
return
# Otherwise

# Check lower level publications, in case later ones are diff specs
# TODO: get metadata on whether a level is a diff spec instead of making this assumption
if failure:
refs, failure = self.foreignRefs.queryRefs(text=text, linkType=linkType, spec=spec, status=status, statusHint=statusHint, linkFor=linkFor, linkForHint=linkForHint, explicitFor=explicitFor, export=export, ignoreObsoletes=True, latestOnly=False)

if failure == "text" or failure == "type":
if linkType in ("property", "propdesc", "descriptor") and text.startswith("--"):
# Custom properties/descriptors aren't ever defined anywhere
Expand Down