Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error correction is not supported (or failed) with Samsung SE-506CB drive #17

Open
sanyifashion opened this issue Oct 12, 2020 · 12 comments

Comments

@sanyifashion
Copy link

The quality scanning feature is supported by the external blu ray burner Samsung SE-506CB, yet it does not work with QPxTool, tested with a BD-XL (TL) disc:

image

@speed47
Copy link
Owner

speed47 commented Oct 12, 2020

The TSSTcorp drives are explicitly blocked using the generic "LiteOn" plugin, by the original author, I don't know why.
The HL-DT-ST drives were also blocked, and it was preventing me using my WH16NS48 drive, which does work correctly with this plugin. So I removed the block.

The corresponding line of code is this one:
https://github.com/speed47/qpxtool/blob/master/plugins/liteon/qscan_plugin.h#L127

Can you compile programs? If yes, you might want to give it a try, removing this line. I'll be interested in the results, of course.
If not, and if you want to try it, I may be able to provide you a special ^recompiled version so you can test.

Of course, obligatory reminder here: I don't know why these drives were blocked in the plugin, my guess is that the author thinks all these drives are just not compatible so to avoid false positives, it just denies them directly in the code. However nowadays will all the rebranded drives everywhere, this is proving wrong. At least this was the case with my drive. But I may be completely wrong and maybe the LiteOn sequence of commands was at some point known to cause problems with some drives. I can't know for sure, and my guess is that commands shouldn't hurt drives, but it's not my drive, it's yours!

@sanyifashion
Copy link
Author

Yes, I saw that TSSTcorp is blocked in another qpxtool repo as well but OptiDriveControl and I think DiscSpeed also works with that so I guess QPxTool should too. I wanted to try out and fix it for myself but I'm rather a .NET/C# developer and it was like 10 years ago since I did anything in C++ and I also don't know Qt at all. I downloaded and tried with that other repo but the build failed (maybe because that version was not ported to Qt 5 yet). Then I guess I have to do it by command line with the makefile to build the whole thing, I'll try it with your repo when I have time. If you can give me some hints in the meantime that would be greatly appreciated.
I'm not afraid that this will hurt the drive, it is just reading data basically, shouldn't do any harm. But even if it would, I'll take the risk.
Btw, there is a folder for tsst in the plugins, I thought that must be adjusted and not the one in the liteon folder. But I saw that dev of the other repo also did the same for allowing the LG to scan so... this is new code I'm not familiar with yet.

@speed47
Copy link
Owner

speed47 commented Oct 13, 2020

No worries, I can put up a precompiled version somewhere for you easily, as I have all the toolchain in place, it's not too much of a hassle.
I agree with you, I think there is no risk in testing those read commands, if it was my drive, I would try it (that's what I did, successfully, with my HL-DT-ST drive).

Here is the libqscan_liteon.dll file with the TSSTcorp block removed:
libqscan_liteon.zip

You can put it in the pl3 folder, and see if it works better with your drive.

If it does, I'll publish a pl4 with this change.

@sanyifashion
Copy link
Author

Yeah I got an LG drive too, which I crossflashed to WH16NS58. I was afraid I would wreck the drive but it worked and scans perfectly. And the same goes for your fix with the Samsung:

image

Thank you, that was all I wanted ;) My only concern is that I have set the speed to 4x and as you can see on the graph it stayed on 2,4x or something. Maybe it's a limitation of the drive, I'll try 5x next time, because that was the maximum I could set.

@speed47
Copy link
Owner

speed47 commented Oct 13, 2020

Yeah I got an LG drive too, which I crossflashed to WH16NS58. I was afraid I would wreck the drive but it worked and scans perfectly.

Exactly what I did too, crossflashed to WH16NS58 firmware 1.V5.
If you have some spare time and a CD somewhere, could you try to scan it? On my drive the behaviour is super strange, the scan goes back and forth (it's easier to see on the console qscan program that qpxtool uses on the background), and aborts before the end of the scan. DVD and BD scans are okay however.

Thank you, that was all I wanted ;) My only concern is that I have set the speed to 4x and as you can see on the graph it stayed on 2,4x or something. Maybe it's a limitation of the drive, I'll try 5x next time, because that was the maximum I could set.

Perfect, thanks for your feedback! I'm releasing pl4 with the change.

speed47 added a commit that referenced this issue Oct 13, 2020
@sanyifashion
Copy link
Author

I found a CD and tried to test it with my LG but it was very strange, like it got into some infinite loop and the scan would go forever...

The graph was also not drawn properly beyond the ~7th minute:
image

I scanned the same disc with my Lite-On and it was done in ~4 minutes without any problem.

@speed47 speed47 reopened this Oct 14, 2020
@speed47
Copy link
Owner

speed47 commented Oct 14, 2020

You're having the same issue as I do on this drive. I think this might be a firmware problem (only on CD scanning), because we have exactly the same drive and firmware.
What happens is more clear on the console version of the tool, but the drive constantly jumps back to previous sections of the disc it already has scanned, that's why the graph seems completely borked.
I'm not sure I've tried scanning a CD on this drive with other tools however, just to be sure it's not a bug in the program (which seems very unlikely). Will do that.

@sanyifashion
Copy link
Author

Okay, I did try it with OptiDriveControl but it couldn't even spin up the drive and was completely frozen, it even froze the the explorer I had to restart and reset the computer... I'll try DiscSpeed later if I can unblock the LG drive.

@speed47
Copy link
Owner

speed47 commented Oct 14, 2020

I tried with OptiDriveControl and an old version of CD Speed, here they react as if the drive didn't supported CD scanning at all.

@intracube-paul
Copy link

Hi, can anyone confirm if these builds are likely to compatible with an LG drive on WH16NS60 v1.02mk firmware - including the reporting of correctable and uncorrectable disc errors?

Do these drives also report jitter statistics?

Thanks.

@speed47
Copy link
Owner

speed47 commented Feb 27, 2022

Not sure this firmware can report errors, only thing I can say for sure is that my BH16NS55 crossflashed to a BH16NS58-DUP (firmware 1V.5) does report errors with both DVD and BD-R. For CD-Rs, this firmware doesn't report errors correctly, however (as discussed above).
Drives reporting errors are starting to be hard to find nowadays.

@intracube-paul
Copy link

intracube-paul commented Mar 2, 2022

Not sure this firmware can report errors, only thing I can say for sure is that my BH16NS55 crossflashed to a BH16NS58-DUP (firmware 1V.5) does report errors with both DVD and BD-R.

Ah ok. If I go ahead and get the LG BH16NS55 with WH16NS60 firmware and manage to get it working, I'll report back. It's a shame there isn't an up to date drive compatibility list.

I've just managed to get the official version of QPxTool (0.8.1) working with my Plextor BD-R PX-B950SA drive (purchased in 2012 and with the original 1.02 firmware). A forum post mentioned that QPxTool neeeds to be run as root to access the error correction feature and sure enough, running as root made this option available (with qscan plugin option left as autodetect). Just thought I'd mention it here in case anyone else makes the same mistake and stumbles on this thread.

I've also run into this issue on the official release #3 so another reason to give this branch a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants