You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm filing an issue rather than sending a PR because the proper fix applies this to all conversions, not just floats, and that's a pretty substantive change, so I wanted to discuss first.
The text was updated successfully, but these errors were encountered:
Is anyone paying attention to this? I feel like it's a pretty common scenario, and there are also many named types in practical use that cannot be converted at the moment.
I'd expect this test to pass:
The fix is pretty easy. Near the beginning of
ToFloat64E
, just after the call toindirect
, add something like:I'm filing an issue rather than sending a PR because the proper fix applies this to all conversions, not just floats, and that's a pretty substantive change, so I wanted to discuss first.
The text was updated successfully, but these errors were encountered: