Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selectable theme (including dark mode) #1952

Open
ptsavol opened this issue Feb 2, 2023 · 1 comment · May be fixed by #1953
Open

Selectable theme (including dark mode) #1952

ptsavol opened this issue Feb 2, 2023 · 1 comment · May be fixed by #1953
Assignees
@ptsavol
Labels
enhancement Enhancement of existing feature UI
Milestone
Roadmap

Comments

@ptsavol
Copy link
Member

ptsavol commented Feb 2, 2023

We should use an external package for setting the theme (look and style) of the application and get rid of most of the custom stylesheets spread around the application. One option I've been looking into is pyqtdarktheme, which supports PySide6 too despite the name. It provides three theme options: 'light', 'dark', or 'auto'. The 'auto' theme means that the application syncs with OS (windows, Linux, mac) theme selected by the user. However, there's a showstopper bug in pyqtdarktheme. Hope there's a fix coming because the package looks promising.
@ptsavol ptsavol added enhancement Enhancement of existing feature UI labels Feb 2, 2023
@ptsavol ptsavol self-assigned this Feb 2, 2023
This was referenced Feb 2, 2023
Draft
Closed
@jkiviluo jkiviluo added this to the V0.7 milestone Feb 10, 2023
@ptsavol ptsavol modified the milestones: V0.7, V1.0 Mar 10, 2023
@ptsavol ptsavol changed the title Selectable theme Selectable theme (including dark mode) Jun 8, 2023
@ptsavol ptsavol mentioned this issue Jun 8, 2023
Closed
@jkiviluo jkiviluo modified the milestones: V1.0, Roadmap Jun 8, 2023
@jkiviluo
Copy link
Member

Would it be possible to fork PyQTDarkTheme and fix the issue they have (seems minor)? On Windows I was able to use system-wide Dark theme without messing up Toolbox, but on Linux Toolbox is almost unusable when having a system-wide dark theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptsavol ptsavol

Labels
enhancement Enhancement of existing feature UI
Projects
None yet
Milestone
Roadmap
Development

Successfully merging a pull request may close this issue.

Os provided theme support spine-tools/Spine-Toolbox
2 participants
@jkiviluo @ptsavol