Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop functionality has issues when tested #2

Open
zakhenry opened this issue Jul 9, 2015 · 0 comments
Open

Stop functionality has issues when tested #2

zakhenry opened this issue Jul 9, 2015 · 0 comments

Comments

@zakhenry
Copy link
Contributor

zakhenry commented Jul 9, 2015

See https://github.com/spira/angular-http-progress/blob/v0.1.0/test/test.ts#L153 in #1 the test has been skipped. With a concrete implementation the functionality of the .stop() method needs to be tested as I suspect there is something wrong with how the stop/restart flow is supposed to work. For now I have skipped the test.

This issue stops a major first release of this module.

@zakhenry zakhenry added the bug label Jul 9, 2015
@zakhenry zakhenry added this to the First stable release milestone Jul 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant