Simplifies adding a bill with keyboard only #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, it looks good to me. I just have one UX remark: isn't it a bit annoying to focus a date field by default? I guess it will display the date picker as soon as the modal opens? |
|
You're right. The datepicker did not display but I think it is more intuitive to focus on "What". I changed this: |
zorun
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes three small changes to simplify adding a bill with only keyboard:
Makes the default focus on the "Add a new bill" button:
In the "Add a new bill" modal, makes the default focus on the first field:
Allows to escape the "Add a new bill" modal with the "Esc" key. (Was this intentionally deactivated?)