Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have spk ls/search hide a version if the only available build is a /src build #1128

Open
dcookspi opened this issue Sep 18, 2024 · 2 comments
Labels
agenda item Items to be brought up at the next dev meeting

Comments

@dcookspi
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

When people list the available versions of a package with the --host/--no-host options, e.g.

> spk ls --host python
3.10.8
3.9.7+r.1
3.9.7
3.7.7+r.1
2.7.11+r.1
2.7.0

versions that only have a /src build appear in the list. This is confusing for people because there isn't a built package for those versions available on the host's OS.

The /src builds make those versions show up because they bypass the host filtering mechanism because they have no baked build options.

Describe the solution you'd like
Change the spk ls <package name> and spk search <partial package name> commands to hide a version if the only available build is a /src build on the OS. But also add a flag that re-enables the current behaviour and puts "(src only)" (or something) next to those versions in the output.

For example:

> spk ls --host python
3.9.7+r.1
3.9.7
3.7.7+r.1
2.7.11+r.1
2.7.0

> spk ls --host --include-src python
3.10.8  (/src only)
3.9.7+r.1
3.9.7 
3.7.7+r.1
2.7.11+r.1
2.7.0
@dcookspi dcookspi added the agenda item Items to be brought up at the next dev meeting label Sep 18, 2024
@jrray
Copy link
Collaborator

jrray commented Sep 18, 2024

Sounds good to me.

@rydrman
Copy link
Collaborator

rydrman commented Sep 18, 2024

From the meeting today:

  • --host should use --no-src by default, no other config stuff needed at this point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agenda item Items to be brought up at the next dev meeting
Projects
None yet
Development

No branches or pull requests

3 participants