Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync bars are shown even when there's nothing to do #1146

Open
rydrman opened this issue Nov 13, 2024 · 0 comments · May be fixed by #1147
Open

Sync bars are shown even when there's nothing to do #1146

rydrman opened this issue Nov 13, 2024 · 0 comments · May be fixed by #1147
Assignees
Labels
bug Something isn't working

Comments

@rydrman
Copy link
Collaborator

rydrman commented Nov 13, 2024

The synced_env function will be called even if nothing was done for the env and so shouldn't create the bars unless they already exist because of some other progress.

fn synced_env(&self, _result: &SyncEnvResult) {
let bars = self.get_bars();

@rydrman rydrman added the bug Something isn't working label Nov 13, 2024
jrray added a commit that referenced this issue Nov 22, 2024
@jrray jrray linked a pull request Nov 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants