Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move linting/code style checks to a separate test #1154

Open
JackDyre opened this issue Aug 9, 2024 · 2 comments
Open

Move linting/code style checks to a separate test #1154

JackDyre opened this issue Aug 9, 2024 · 2 comments

Comments

@JackDyre
Copy link
Contributor

JackDyre commented Aug 9, 2024

I would be nice if the linting/code style tests were in their own test. It is kinda confusing when I make a change and all the tests fail, but it is only because I forgot to run the linting commands and the all of the tests passed.

@stephanebruckert
Copy link
Member

stephanebruckert commented Aug 10, 2024

We could split linting/testing into different workflows so it shows more clearly what's green or red. Also we could only run the linting step or workflow when the PR is not a draft? (actually a bad idea, someone might want to focus mostly on linting)

On your side you could also look at setting up flake8 in your code editor so it fixes code automatically.

@dieser-niko
Copy link
Member

While we're at it, we might want to remove the line pip install -Iv enum34==1.1.6, as we don't support versions below 3.4 anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants