Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RabbitMessageChannelBinder fails to initialize LocalizedQueueConnectionFactory if ssl.enabled is not specified #2331

Open
sobychacko opened this issue Mar 30, 2022 · 0 comments

Comments

@sobychacko
Copy link
Contributor

@vkochnev commented on Wed Nov 03 2021

https://github.com/spring-cloud/spring-cloud-stream-binder-rabbit/blob/09c8b9bdc5a172b4034b32ff4d70b094ccb616b7/spring-cloud-stream-binder-rabbit/src/main/java/org/springframework/cloud/stream/binder/rabbit/RabbitMessageChannelBinder.java#L262

Shouldn't it be this.rabbitProperties.getSsl().determineEnabled() instead? The problem is if spring.rabbitmq.ssl.enabled is not specified in application.yml this line fails with NPE.

Also if virtualHost, username and/or password are specified on addresses instead of separate fields current implementation will ignore them, use of determine* alternatives might help here also (It looks like I should file these separately, but I'm not sure it makes sense).

More comprehensive solution might be discussed in spring-projects/spring-amqp#1384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant