Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VectorStoreChatMemoryAdvisor builder class should have additional methods to set all properties #1823

Open
markpollack opened this issue Nov 25, 2024 · 1 comment
Open

VectorStoreChatMemoryAdvisor builder class should have additional methods to set all properties #1823

markpollack opened this issue Nov 25, 2024 · 1 comment
Milestone
1.0.0-M5

Comments

@markpollack
Copy link
Member

Currently, order and other properties are not able to be set by the builder. We should deprecate most of the current constructors and use the builder.
@markpollack markpollack added this to the 1.0.0-M5 milestone Nov 25, 2024
@markpollack markpollack mentioned this issue Nov 25, 2024
Closed
@ogbozoyan ogbozoyan mentioned this issue Nov 25, 2024
Open
@ogbozoyan
Copy link

Agree with you. Builder a much prettier approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0-M5
Development

No branches or pull requests
2 participants
@markpollack @ogbozoyan