Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a configuration property to customize the Tomcat connector's max parameter count #43275

Open
rafaello7 opened this issue Nov 23, 2024 · 1 comment
Open

Add a configuration property to customize the Tomcat connector's max parameter count #43275

rafaello7 opened this issue Nov 23, 2024 · 1 comment
Labels
status: waiting-for-internal-feedback An issue that needs input from a member or another Spring Team status: waiting-for-triage An issue we've not yet triaged

Comments

@rafaello7
Copy link

Tomcat has a limit of HTML form parameter count, which is 10000 by default. Currently the limit change is possible in Spring Boot only programmatically. On the other hand, the Undertow embedded server has a property server.undertow.max-parameters. Could it be possible to have such property for Tomcat also?
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 23, 2024
@wilkinsona wilkinsona changed the title Add property to customize embedded Tomcat maximum HTML form parameter count Add a configuration property to customize the Tomcat connector's max parameter count Nov 23, 2024
@wilkinsona
Copy link
Member

Thanks for the suggestion, @rafaello7.

It looks like the proposed property would map onto org.apache.catalina.connector.Connector#setMaxParameterCount(int). There's also org.eclipse.jetty.ee10.servlet.ServletContextHandler#setMaxFormKeys(int) for Jetty that looks like it serves a very similar purpose. We may want to add a property for that as well.

@violetagg is there a similar setting in Reactor Netty?

@wilkinsona wilkinsona added the status: waiting-for-internal-feedback An issue that needs input from a member or another Spring Team label Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: waiting-for-internal-feedback An issue that needs input from a member or another Spring Team status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wilkinsona @rafaello7 @spring-projects-issues