Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove an extra level in the class hierarchy #1574

Closed
wants to merge 1 commit into from

Conversation

valery1707
Copy link
Contributor

Simplify class hierarchy by moving RowToOffsetDateTimeConverter, RowToStringConverter, RowToUuidConverter and RowToZonedDateTimeConverter out of RowToNumberConverterFactory class.

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 24, 2023
@mp911de mp911de self-assigned this Aug 7, 2023
mp911de pushed a commit that referenced this pull request Sep 13, 2023
@mp911de mp911de closed this in 6d1d966 Sep 13, 2023
mp911de pushed a commit that referenced this pull request Sep 13, 2023
@mp911de mp911de added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 13, 2023
@mp911de mp911de added this to the 3.0.10 (2022.0.10) milestone Sep 13, 2023
@mp911de
Copy link
Member

mp911de commented Sep 13, 2023

Thank you for your contribution. That's merged and backported now.

@valery1707 valery1707 deleted the patch-1 branch October 3, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants