Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for forein keys in schema generation within aggregates #1599

Closed
schauder opened this issue Sep 1, 2023 · 5 comments
Closed

Add support for forein keys in schema generation within aggregates #1599

schauder opened this issue Sep 1, 2023 · 5 comments
Labels
in: schema-generation status: ideal-for-contribution An issue that a contributor can help us with type: enhancement A general enhancement

Comments

@schauder
Copy link
Contributor

schauder commented Sep 1, 2023 •
edited
Loading

#756 introduced Liquibase based schema generation, but it ignores foreign keys. This issue should change this.

We should:

  • create the back reference pointing back to the parent entity.
  • create the key column for List and Map typed properties.
  • create appropriate indexes and constraints for these columns.
@schauder schauder added status: ideal-for-contribution An issue that a contributor can help us with in: schema-generation type: enhancement A general enhancement labels Sep 1, 2023
@schauder schauder changed the title Add support for forein keys in schema generation Add support for forein keys in schema generation within aggregates Sep 1, 2023
@schauder schauder mentioned this issue Sep 1, 2023
Open
@pschijven
Copy link

Hi @schauder, if this issue is not time-critical, I would be happy to help out with this one.

@schauder
Copy link
Contributor Author

schauder commented Sep 6, 2023

Great, go ahead. Let me know if you need help.

@pschijven
Copy link

Hi @schauder, I suddenly received a short project at work, so at the moment I'm unable to spend time on this issue.

If it is still open in about 2 or 3 weeks, I'd be happy to continue with it.

kobaeugenea added a commit to kobaeugenea/spring-data-relational that referenced this issue Sep 30, 2023
@kobaeugenea
Add support for forein keys in schema generation within aggregates.
cef626b 
Closes spring-projects#1599
Related tickets spring-projects#756, spring-projects#1600
@kobaeugenea kobaeugenea mentioned this issue Sep 30, 2023
Closed
4 tasks
@kobaeugenea
Copy link
Contributor

Hi everyoune!
@pschijven As you didn't work on it for some time I created pull request. Hope you don't mind.
@schauder Could you please review it and if it seems okay, I would be happy to work on #1600.

@pschijven
Copy link

Hi @kobaeugenea, no worries! 🙂

schauder pushed a commit that referenced this issue Oct 19, 2023
@kobaeugenea @schauder
Add support for forein keys in schema generation within aggregates.
6d1c9be 
Closes #1599
Related tickets #756, #1600
schauder added a commit that referenced this issue Nov 24, 2023
@schauder
Polishing.
5342e02 
Removed tests for circular references since they are not supported by Spring Data Relational.

Closes #1599
See #756, #1600
Original pull request #1629
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: schema-generation status: ideal-for-contribution An issue that a contributor can help us with type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
3 participants
@schauder @kobaeugenea @pschijven