Upgrade to Oracle Free #1665
Labels
status: waiting-for-triage
An issue we've not yet triaged
Comments
spring-projects-issues
added
the
status: waiting-for-triage
|
Great. What is the difference between |
schauder
added a commit
that referenced
this issue
Nov 17, 2023
Also moving to the label, hoping it will start less slow. Closes #1665
Hi @schauder, you have all the details here. HTH |
|
Thanks, I also just found the description myself. |
1 similar comment
|
Thanks, I also just found the description myself. |
schauder
added a commit
that referenced
this issue
Nov 17, 2023
Also moving to the `faststart` label, hoping it will start less slow. Closes #1665
mp911de
changed the title
|
Seems there are issues with the container: Code: DockerImageName dockerImageName = DockerImageName.parse("gvenzl/oracle-free:23.3-slim-faststart");
OracleContainer container = new OracleContainer(dockerImageName).withReuse(true);
container.start(); |
|
timeout? I think you can increase it. |
|
I currently suspect this is fluke. We'll take another look next week. |
|
Hm, I believe that's the timeout set within the Testcontainers module which is currently set to 60 seconds, see: and I thought 60 seconds would be enough to pull the image and start the container as Testcontainers' own tests didn't run into that issue but the time is heavily impacted by the download speed and CPU clock speed for extracting the compressed layers. For what it's worth, the database was almost up, another 3-5 seconds and it would have been there. Ah well :)
@schauder, the difference is the tradeoff between image size and actual database startup time. The Here is what it boils down to: If you have a case where you start and destroy many containers from the same image, you will want to use the If you have a case where all you do is pull the image, startup the container run some tests and throw it all away again, you are most often better off using the non-faststart For reference, see this GitHub Actions run: https://github.com/gvenzl/github-actions-tests/actions/runs/6911512051 You will see that the three |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi all (and @schauder),
This is a follow-on ticket from the discussions in #1528.
This Wednesday, Atomic Jar introduced a new Oracle Free module, which means that these lines:
spring-data-relational/spring-data-jdbc/src/test/java/org/springframework/data/jdbc/testing/OracleDataSourceConfiguration.java
Lines 58 to 62 in 42e786c
can now be further simplified to:
The following dependency is required:
Looking at the current code in OracleDataSourceConfiguration, I think the line
withDatabase('freepdb2')can also be removed. I think we added that because the default database names between oracle-xe and oracle-free TC modules are incompatible.Removing that line means no new database
XEPDB2will be created at container startup which will further improve overall startup time.Thanks,
The text was updated successfully, but these errors were encountered: