Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the assembly from JdbcRepositoryFactoryBean to the JdbcRepositoryFactory #373

Open
Tracked by #1610
spring-projects-issues opened this issue Oct 25, 2017 · 0 comments
Open
Tracked by #1610

Move the assembly from JdbcRepositoryFactoryBean to the JdbcRepositoryFactory #373

spring-projects-issues opened this issue Oct 25, 2017 · 0 comments
Assignees
@schauder
Labels
type: task A general task

Comments

@spring-projects-issues
Copy link

Jens Schauder opened DATAJDBC-140 and commented

The Factory should have a constructor with minimal dependencies, (e.g. Datasource, instead of JdbcTemplate) and construct everything else from that.

Leave as little logic in the ..Bean since it is just an adapter to the spring world and any logic in there would need to get recreated for CDI or similar

Issue Links:

  • DATAJDBC-151 JdbcRepositoryFactoryBean must be restructured to support other Spring modules
@spring-projects-issues spring-projects-issues added the type: enhancement A general enhancement label Dec 31, 2020
mp911de added a commit that referenced this issue Feb 21, 2022
@mp911de @schauder
#373 - Use SpelQueryContext for expression query parsing.
687142e 
We now use SpelQueryContext and SpelExtractor for analysis and rewrite of queries using SpEL.

Original pull request: #376.
mp911de added a commit that referenced this issue Feb 21, 2022
@mp911de @schauder
#373 - Extract test into ExpressionQueryUnitTests.
9e11626 
Original pull request: #376.
mp911de pushed a commit that referenced this issue Feb 21, 2022
@schauder
#373 - Polishing.
06cc4e2 
Using soft assertions for more expressive test failures.

Original pull request: #376.
@mp911de mp911de added type: task A general task and removed type: enhancement A general enhancement labels Sep 13, 2023
@mp911de mp911de mentioned this issue Sep 13, 2023
Open
5 tasks
@mp911de mp911de changed the title Move the assembly from JdbcRepositoryFactoryBean to the JdbcRepositoryFactory [DATAJDBC-140] Move the assembly from JdbcRepositoryFactoryBean to the JdbcRepositoryFactory Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schauder schauder

Labels
type: task A general task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@schauder @mp911de @spring-projects-issues