Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix id setting for partial updates of collections of immutable types #1920

Closed
wants to merge 2 commits into from

Conversation

schauder
Copy link
Contributor

We gather immutable entities of which the id has changed, in order to set them as values in the parent entity.
We now also gather unchanged entities.
So they get set with the changed one in the parent.

Closes #1907

We gather immutable entities of which the id has changed, in order to set them as values in the parent entity.
We now also gather unchanged entities.
So they get set with the changed one in the parent.

Closes #1907
@schauder schauder requested a review from mp911de October 23, 2024 07:59
@mp911de mp911de changed the title Fix id setting for partial updates of collections of immutables. Fix id setting for partial updates of collections of immutable types Oct 25, 2024
@mp911de mp911de added the type: bug A general bug label Oct 25, 2024
@mp911de mp911de added this to the 3.2.12 (2023.1.12) milestone Oct 25, 2024
mp911de pushed a commit that referenced this pull request Oct 25, 2024
We gather immutable entities of which the id has changed, in order to set them as values in the parent entity.
We now also gather unchanged entities.
So they get set with the changed one in the parent.

Closes #1907
Original pull request: #1920
mp911de added a commit that referenced this pull request Oct 25, 2024
Eliminate potential NoSuchElementException from unchecked Optional.get usage. Simplify stream. Return Staged value, fix Nullability annotations.

See #1907
Original pull request: #1920
mp911de pushed a commit that referenced this pull request Oct 25, 2024
We gather immutable entities of which the id has changed, in order to set them as values in the parent entity.
We now also gather unchanged entities.
So they get set with the changed one in the parent.

Closes #1907
Original pull request: #1920
mp911de added a commit that referenced this pull request Oct 25, 2024
Eliminate potential NoSuchElementException from unchecked Optional.get usage. Simplify stream. Return Staged value, fix Nullability annotations.

See #1907
Original pull request: #1920
mp911de pushed a commit that referenced this pull request Oct 25, 2024
We gather immutable entities of which the id has changed, in order to set them as values in the parent entity.
We now also gather unchanged entities.
So they get set with the changed one in the parent.

Closes #1907
Original pull request: #1920
mp911de added a commit that referenced this pull request Oct 25, 2024
Eliminate potential NoSuchElementException from unchecked Optional.get usage. Simplify stream. Return Staged value, fix Nullability annotations.

See #1907
Original pull request: #1920
@mp911de mp911de closed this Oct 25, 2024
@mp911de mp911de deleted the issue/1907-partial-insert-immutables branch October 25, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return value of Repository.save contains only added elements of @MappedCollection, not existing ones
2 participants