Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nature Section Heading Improvements #670

Open
alexkilgour opened this issue Jan 27, 2022 · 3 comments
Open

Nature Section Heading Improvements #670

alexkilgour opened this issue Jan 27, 2022 · 3 comments
Labels
enhancement New feature or request nature nature toolkit issue role: FED stale this issue is more than 30 days old

Comments

@alexkilgour
Copy link
Collaborator

Some improvements need to be made to the nature footer component:

  • Check that the template is up to date from Oscar
  • Should the icon come from the brand-context
@alexkilgour alexkilgour added enhancement New feature or request nature nature toolkit issue role: FED labels Jan 27, 2022
@alexkilgour alexkilgour mentioned this issue Jan 27, 2022
Merged
@benjclark
Copy link
Contributor

See this discussion for possible options for importing icons in to component view templates

https://springernature.slack.com/archives/C75DHBTBP/p1652433702610969

@ricky-lau
Copy link
Contributor

Recently merged in #757. I looked at how it was handled in global-breadcrumbs as it also has the same icon.

@sturobson
Copy link
Contributor

There has been no update on this issue for 30 days. It is now marked as "stale". If you think this issue is still relevant and needs attention then reply with an update. If there is no update in 14 days, this issue will be closed.

@sturobson sturobson added the stale this issue is more than 30 days old label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request nature nature toolkit issue role: FED stale this issue is more than 30 days old
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alexkilgour @sturobson @benjclark @ricky-lau