Add user journeys and additional info to survey link #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Wrap long lines - Add userJourneys and additionalInfo parameters and their values to the survey link, so that they can be combined with the survey input users provide for us
In OASIS, we use asdf rather than nvm, so this helps.
benjclark
reviewed
Nov 14, 2023
toolkits/global/packages/global-customer-satisfaction-input/HISTORY.md
Outdated
Show resolved
Hide resolved
benjclark
reviewed
Nov 14, 2023
toolkits/global/packages/global-customer-satisfaction-input/js/customer-satisfaction-input.js
Outdated
Show resolved
Hide resolved
benjclark
approved these changes
Nov 14, 2023
RSeidelsohn
deleted the
add-user-journeys-and-additional-info-to-survey-link
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In OASIS, we use Survey Monkey to send our customers to an additional survey where they can tell us why they chose the rating they selected.
In these surveys, we additionally want to see the
userJourneyand theadditionalInfoparameters we add to the customer satisfaction Handlebars template.For that reason, I enhanced the javascript of the global customer satisfaction tool so that it checks for either parameter's existence and if they are not empty, appends them to the searchParams of the generated survey URL.
Additionally, I made the existing Jest test for that component a bit more flexible and added tests for the two new parameters. Also, I added documentation for these additions to the README, where I removed a duplicated section that was there before.