Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternate Predbat runs take twice as long #1565

Open
Ashpork opened this issue Oct 25, 2024 · 3 comments
Open

Alternate Predbat runs take twice as long #1565

Ashpork opened this issue Oct 25, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@Ashpork
Copy link

Ashpork commented Oct 25, 2024

Describe the bug
Alternate Predbat runs take twice as long. And the longer runs appear to fire the charge/discharge services twice.

Expected behavior
On each run, only fire the charge_start_service, charge_stop_service and discharge_start_service once. Be consistent between runs

Predbat version
v8.5.1

Environment details
SE, 1 inverter, 1 battery
Predbat ran as an Addon

Screenshots
Compare the two log files attached.
longLog.txt
shortLog.txt

@gcoan
Copy link
Collaborator

gcoan commented Oct 25, 2024

Alternate predbat runs will take differing run times, if you look at the logfile, by default predbat runs every 5 minutes to execute the plan (as the plan is at 5 minutes granularity), but Predbat only recalculates the plan every 10 minutes.

So you will get a shorter execution run then a longer run. You can change these frequencies if you want

@Ashpork
Copy link
Author

Ashpork commented Oct 25, 2024

Of course, just spotted the configuration in the apps.yaml. Apologies.

However why trigger a inverter service action at the end of the plan execution, and then again at the end of the recalculation of the plan?

@springfall2008
Copy link
Owner

Essentially after the re-plan the execute is called again in case it has changed.

Probably the enhancement here is not to repeat the service if it was called already with the same values

@springfall2008 springfall2008 added the enhancement New feature or request label Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants