Fix all whitespace -- alternative approach #216
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented an alternative approach that avoids reparsing the output for newlines in the
IndentWriter
.Basic idea was to use a specialized
IndentWriter
everywhere. This way, we can call the newline-specialized methodwriteLines
inappendText
.Note however, that besides changing a lot of interfaces this implementation made the implementation of the
LatchedWriter
a lot more complicated because it also needs to be newline aware in its buffer.