This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
bugfix/dispose-stream-for-corrupted-archive-check #178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
While implementing an archive backup system using this library and doing an intregity check on a purposely corrupted file, I was no longer able to access the file until the next GC.
A quick browse of the code, I noticed that the public bool Check() method catches all exceptions and just returns false, but since streams are shared between several method, there appears to be some sort of state regarding when the stream can be closed. And an exception bubbling from the InitArchiveFileData(diseposeStream: false); method, would prevent the stream from being closed.
This change ensures the stream can be closed if an exception is thrown, however, maybe the "correct" solution is to just change the disposeStream parameter to true in the InitArchiveFileData method.
Steps to reproduce: