Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Ability to "find" text #252

Open
sepsol opened this issue Mar 5, 2024 · 4 comments
Open

Feature Request: Ability to "find" text #252

sepsol opened this issue Mar 5, 2024 · 4 comments
Labels

Comments

@sepsol
Copy link

sepsol commented Mar 5, 2024

Possibly using Regex as well

@zxrfire
Copy link

zxrfire commented Aug 24, 2024

I agree with this feature. Please add ctrl+f capability to halloy like other irc clients has, makes it easier to search.

@gurgl
Copy link

gurgl commented Nov 10, 2024

I'm working on this feature. Please tell me to stop if anyone is already working on it.

@tarkah
Copy link
Member

tarkah commented Nov 11, 2024

I'm working on this feature. Please tell me to stop if anyone is already working on it.

Awesome @gurgl! Btw we have a way to scroll to messages now checkout scroll_to_message in scroll_view.

So you could use this against a list of found messages from the search text, with next / prev functionality.

I'd recommend exposing something on the History API, such as find_text which returns a vec of message references. Store that in scroll view state along with current index into that vec for next / prev and then invalidate / refind it each time they enter text

@gurgl
Copy link

gurgl commented Nov 13, 2024

I'd recommend exposing something on the History API, such as find_text which returns a vec of message references. Store that in scroll view state along with current index into that vec for next / prev and then invalidate / refind it each time they enter text

Sweet, I'll take a look on those parts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants