Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rgba contrast checking #134

Open
wants to merge 38 commits into
base: master
Choose a base branch
from
Open

add rgba contrast checking #134

wants to merge 38 commits into from

Commits on Apr 29, 2014

  1. Configuration menu
    Copy the full SHA
    3a4305b View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2014

  1. Configuration menu
    Copy the full SHA
    247b864 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    772f653 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2014

  1. Configuration menu
    Copy the full SHA
    afc99ba View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b3d28fc View commit details
    Browse the repository at this point in the history
  3. Don't warn about rgba anymore

    No need to, we are doing the maths!
    mfairchild365 committed Jun 27, 2014
    Configuration menu
    Copy the full SHA
    b8d7684 View commit details
    Browse the repository at this point in the history
  4. Convert to a colour string

    The rest of the code expects bgColour to be a string
    mfairchild365 committed Jun 27, 2014
    Configuration menu
    Copy the full SHA
    eaa1309 View commit details
    Browse the repository at this point in the history
  5. Return rgb channels as %

    Everything else expects them as %.  Also, rework to reduce rounding problems.
    mfairchild365 committed Jun 27, 2014
    Configuration menu
    Copy the full SHA
    e2159c5 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e730b35 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    36c217f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b8d4fa5 View commit details
    Browse the repository at this point in the history
  9. Correctly calculate layered transparencies

    Take this structure of backgrounds for example, 1 being the closest element:
    1. rgba(10,10,10, .5);
    2. rgba(10,10,50, .1);
    3. rgb(10,10,250);
    
    We need to transform background 2 into a solid color before we transform background 1 into a solid colour.
    mfairchild365 committed Jun 27, 2014
    Configuration menu
    Copy the full SHA
    7ce911b View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2014

  1. Configuration menu
    Copy the full SHA
    834d0b7 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2014

  1. Configuration menu
    Copy the full SHA
    e662366 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2014

  1. Configuration menu
    Copy the full SHA
    203031f View commit details
    Browse the repository at this point in the history
  2. Include an alpha

    mfairchild365 committed Jul 9, 2014
    Configuration menu
    Copy the full SHA
    338cd1d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    48ad4e7 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2014

  1. Make absolutely positioned contrast errors warnings

    We can't reliably compute the contrast of text over a background if the text is absolutely positioned over the background of another element that isn't a direct parent of the text element.
    mfairchild365 committed Aug 11, 2014
    Configuration menu
    Copy the full SHA
    20fa290 View commit details
    Browse the repository at this point in the history
  2. Remove trailing comma

    mfairchild365 committed Aug 11, 2014
    Configuration menu
    Copy the full SHA
    bab8109 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #1 from mfairchild365/contrast-abs

    Make absolutely positioned contrast errors warnings
    kabel committed Aug 11, 2014
    Configuration menu
    Copy the full SHA
    7fe9b5c View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2014

  1. Configuration menu
    Copy the full SHA
    5c1ad9f View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2014

  1. Merge remote-tracking branch 'squizlabs/master'

    Conflicts:
    	Standards/WCAG2AAA/Sniffs/Principle1/Guideline1_4/1_4_3_Contrast.js
    mfairchild365 committed Nov 7, 2014
    Configuration menu
    Copy the full SHA
    0a8d34f View commit details
    Browse the repository at this point in the history
  2. msg is already defined

    was causing an error
    mfairchild365 committed Nov 7, 2014
    Configuration menu
    Copy the full SHA
    a9e6962 View commit details
    Browse the repository at this point in the history
  3. Fix false positive

    Only push an error if `warning === false`
    mfairchild365 committed Nov 7, 2014
    Configuration menu
    Copy the full SHA
    b6f2758 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #2 from mfairchild365/master

    Merge with HTML_Codesniffer
    kabel committed Nov 7, 2014
    Configuration menu
    Copy the full SHA
    f92716d View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2014

  1. Don't try to check SVG objects

    Don't process the element if no body was could be found.
    This was causing a fatal js error.
    mfairchild365 committed Dec 5, 2014
    Configuration menu
    Copy the full SHA
    bf48fb6 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #3 from mfairchild365/svg-objects

    Don't try to check SVG objects
    kabel committed Dec 5, 2014
    Configuration menu
    Copy the full SHA
    77c9a05 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #4 from squizlabs/master

    Merge with upstream
    kabel committed Dec 5, 2014
    Configuration menu
    Copy the full SHA
    9de66d4 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2015

  1. Merge branch 'master' of https://github.com/squizlabs/HTML_CodeSniffer

    Conflicts:
    	Standards/WCAG2AAA/Sniffs/Principle1/Guideline1_4/1_4_3_Contrast.js
    	Standards/WCAG2AAA/Sniffs/Principle4/Guideline4_1/4_1_2.js
    mfairchild365 committed Mar 3, 2015
    Configuration menu
    Copy the full SHA
    ebb3e0b View commit details
    Browse the repository at this point in the history
  2. Merge pull request #5 from mfairchild365/master

    Merge with upstream
    kabel committed Mar 3, 2015
    Configuration menu
    Copy the full SHA
    883a855 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2016

  1. Configuration menu
    Copy the full SHA
    935eb35 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2016

  1. Check for the will-change: 'transform' background image performance hack

    This was throwing a false positive in some cases, where it should trigger a manual check instead.
    mfairchild365 committed May 31, 2016
    Configuration menu
    Copy the full SHA
    4f6aff2 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #6 from mfairchild365/background-will-change-trans…

    …form
    
    Check for the will-change: 'transform' background image performance hack
    kabel committed May 31, 2016
    Configuration menu
    Copy the full SHA
    a11e79c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8af0f5e View commit details
    Browse the repository at this point in the history
  4. Fix merge with upstream

    mfairchild365 committed May 31, 2016
    Configuration menu
    Copy the full SHA
    90710cd View commit details
    Browse the repository at this point in the history
  5. Merge pull request #7 from mfairchild365/master

    Merge with upstream
    kabel committed May 31, 2016
    Configuration menu
    Copy the full SHA
    d2a6021 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2016

  1. Configuration menu
    Copy the full SHA
    f200370 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #8 from mfairchild365/hidden-inputs

    form controls don't need labels if they are display:none
    kabel authored Aug 30, 2016
    Configuration menu
    Copy the full SHA
    9bc316c View commit details
    Browse the repository at this point in the history